Open
Conversation
Signed-off-by: Madhura Mendis <madhuramendis@gmail.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds a new Enterprise site page with associated styles, registers a client-side gtag guard module, and updates the navbar to include a left-positioned "Enterprise" link in the Docusaurus config. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/enterprise.module.css`:
- Around line 137-139: The current CSS rule .cButton:focus { outline: none; }
removes keyboard focus visibility and must be replaced with a visible,
accessible focus style; update the selector to use .cButton:focus-visible (or
keep :focus for broader support) and add a clear high-contrast focus indicator
(for example a 2px solid outline or visible box-shadow and outline-offset) that
uses an accessible color token (e.g., --focus-color) so keyboard users can see
focus on the CTA button; ensure you remove the outline:none rule and add the new
focus style to the .cButton ruleset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e8738ea5-9e90-4eb6-9ed7-cd76ec8fe080
📒 Files selected for processing (3)
docusaurus.config.tssrc/pages/enterprise.module.csssrc/pages/enterprise.tsx
Comment on lines
+137
to
+139
| .cButton:focus { | ||
| outline: none; | ||
| } |
Contributor
There was a problem hiding this comment.
Do not remove keyboard focus visibility on the CTA button.
Line 137-Line 139 removes focus outline with no replacement, which is an accessibility regression for keyboard users.
💡 Proposed fix
-.cButton:focus {
- outline: none;
-}
+.cButton:focus-visible {
+ outline: 2px solid var(--ifm-color-primary);
+ outline-offset: 2px;
+}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .cButton:focus { | |
| outline: none; | |
| } | |
| .cButton:focus-visible { | |
| outline: 2px solid var(--ifm-color-primary); | |
| outline-offset: 2px; | |
| } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/pages/enterprise.module.css` around lines 137 - 139, The current CSS rule
.cButton:focus { outline: none; } removes keyboard focus visibility and must be
replaced with a visible, accessible focus style; update the selector to use
.cButton:focus-visible (or keep :focus for broader support) and add a clear
high-contrast focus indicator (for example a 2px solid outline or visible
box-shadow and outline-offset) that uses an accessible color token (e.g.,
--focus-color) so keyboard users can see focus on the CTA button; ensure you
remove the outline:none rule and add the new focus style to the .cButton
ruleset.
Signed-off-by: Madhura Mendis <madhuramendis@gmail.com>
Signed-off-by: Madhura Mendis <madhuramendis@gmail.com>
Signed-off-by: Madhura Mendis <madhuramendis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issues
Checklist
sidebars.tsif adding a new documentation pagenpm run startto preview the changes locallynpm run buildto ensure the build passes without errors